Attention is currently required from: n0k0.
Jenkins Builder has posted comments on this change by n0k0. ( https://gerrit.osmocom.org/c/libsmpp34/+/42889?usp=email )
Change subject: smpp34_unpack: bound C_OCTET scan with strnlen() ......................................................................
Patch Set 3:
(4 comments)
File src/smpp34_unpack.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libsmpp34/+/42889/comment/3b97a1da_50a2fe14?usp... : PS3, Line 130: lenval = strnlen( (char*) aux, left ) + 1;\ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libsmpp34/+/42889/comment/ccecbba5_d7b99fc2?usp... : PS3, Line 130: lenval = strnlen( (char*) aux, left ) + 1;\ "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libsmpp34/+/42889/comment/0499e315_db184520?usp... : PS3, Line 130: lenval = strnlen( (char*) aux, left ) + 1;\ space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libsmpp34/+/42889/comment/8fc592ab_6a081a5f?usp... : PS3, Line 130: lenval = strnlen( (char*) aux, left ) + 1;\ space prohibited before that close parenthesis ')'