Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email ) Change subject: trx, bts: add optional WebSDR backend (callback-based transport) ...................................................................... Patch Set 1: (12 comments) File src/common/osmux.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/e8ab09a1_5a0a1b5e?usp=... : PS1, Line 132: if (rc < 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/985216ae_975586d0?usp=... : PS1, Line 578: int ws_osmux_push_raw_data(const char* data, size_t sz) "foo* bar" should be "foo *bar" File src/osmo-bts-trx/osmo-bts-trx-websdr.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/3d3634d5_839c9df6?usp=... : PS1, Line 48: #endif /* OSMO_BTS_TRX_WEBSDR_H */ adding a line without newline at end of file File src/osmo-bts-trx/osmo-bts-trx-websdr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/b55351d0_1e9e0a74?usp=... : PS1, Line 66: int16_t sdr_send_buffer[ MAX_BUFS * BURST_DURATION * 2 ]; space prohibited after that open square bracket '[' Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/892cd763_63b28d95?usp=... : PS1, Line 66: int16_t sdr_send_buffer[ MAX_BUFS * BURST_DURATION * 2 ]; space prohibited before that close square bracket ']' Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/55b7f8ae_67deaaac?usp=... : PS1, Line 67: uint64_t sdr_send_bts[ MAX_BUFS ]; space prohibited after that open square bracket '[' Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/15ad982a_a61669d8?usp=... : PS1, Line 67: uint64_t sdr_send_bts[ MAX_BUFS ]; space prohibited before that close square bracket ']' Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/b4e3c6c2_bac33ec3?usp=... : PS1, Line 91: char *params[] = { char * array declaration might be better as static const Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/16fe29cc_e13d658c?usp=... : PS1, Line 96: const size_t num_params = sizeof(params) / sizeof(params[0]); Prefer ARRAY_SIZE(params) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/cfec4766_9eb5d84e?usp=... : PS1, Line 156: if (start_fn == ~0u) { braces {} are not necessary for single statement blocks File src/osmo-bts-trx/scheduler_trx.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/519d8572_d5e300a7?usp=... : PS1, Line 789: void on_sched_timer(unsigned frames) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/091b07fd_0fa51c5b?usp=... : PS1, Line 799: #endif /* ENABLE_WEBSDR */ adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idebd588f33afd85021813ad5821391781db683a9 Gerrit-Change-Number: 42703 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp@gmail.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 27 Apr 2026 00:16:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No