pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27521 ) Change subject: clean-up pkg-config files: Make use of "Requires" as documented ...................................................................... Patch Set 2: (1 comment) File libosmogb.pc.in: https://gerrit.osmocom.org/c/libosmocore/+/27521/comment/eabae010_9ca8f9d8 PS1, Line 9: Requires: libosmocore, libosmovty
Done libosmocore requiring talloc is totally orthogonal to having talloc listed here. libosmogb using talloc directly means it should show up here. IIRC in pkgconfig there's the concept of "internally using" some dep vs really exporting its linking flags to users of the lib.
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ab1fe8e4bbfc120b471d6c9f2312a89dbc7d42b Gerrit-Change-Number: 27521 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 24 Mar 2022 15:25:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment