Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email )
Change subject: libosmo-trx/ep: add TRX endpoint module ......................................................................
Patch Set 8: Code-Review+1
(1 comment)
File libosmo-trx/src/trx_ep.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/f700db8e_a3072deb?usp=... : PS8, Line 675: * For TRXDv2, the PDUs are batched: they get accumulated until this I wonder what's the point in having the breaker case (bi=NULL) included into this same function, instead of having a separate API osmo_trx_ep_send_burst_ind_fin() or similar, which would make code more clearer and avoid extra branching and complexity in this function.