Attention is currently required from: laforge, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email )
Change subject: firmware: Drop CEMU_TX_DATA when sim is in-active
......................................................................
Patch Set 6:
(1 comment)
File firmware/libcommon/source/card_emu.c:
https://gerrit.osmocom.org/c/simtrace2/+/43003/comment/7ba86d80_054de7bd?usp... :
PS5, Line 218: /* if the card should enque messages */
wording is slightly sub-optimal: A card itself (like an actual SIM) doesn't queue messages, right? […]
I changed the wording. If this is not fitting, please recommend a better name.
--
To view, visit
https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I796e548225a742cddfde12bd6a60e4d2e5c04c8f
Gerrit-Change-Number: 43003
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 12 Aug 2026 13:52:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org