Attention is currently required from: arehbein, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33193 ) Change subject: Add osmo_io support to osmo_stream_cli and osmo_stream_srv ...................................................................... Patch Set 2: (2 comments) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/f11619d3_478b4c82 PS1, Line 1758: OSMO_ASSERT
Wow, I just saw that osmo_stream_srv_link_create_iofd() is a 100% copy of the old variant. […] I don't know the code like you do, but I generally agree with your point here. We don't have sockets with tens of thousands of pending accept calls...
https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/63e5bf9e_2d0c2c2d PS1, Line 1775: talloc_free
No, it simply allocates memory and fills in the struct. […] Done
-- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33193 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I2f52c7107c392b6f4b0bf2a84f8c873c084a200c Gerrit-Change-Number: 33193 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: arehbein <arehbein@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jun 2023 15:51:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: daniel <dwillmann@sysmocom.de> Gerrit-MessageType: comment