17 Aug
2023
17 Aug
'23
3:13 p.m.
Attention is currently required from: dexter.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34134 )
Change subject: pcuif_proto: get rid of _DT, _dt (Direct TLLI) ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File include/osmocom/pcu/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/34134/comment/032edab9_9717a475 PS1, Line 21: #define PCU_IF_MSG_DATA_CNF_DT 0x11 /* confirm (using message id) */ I'm not sure if we need backwards compatibility here (keep the old define next to the new one)? But given that Pau already +1'd probably not.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34134
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If641b507dcb6b176109c99dce7cff2a7561364b0
Gerrit-Change-Number: 34134
Gerrit-PatchSet: 1
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 17 Aug 2023 13:13:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment