Attention is currently required from: laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27070 ) Change subject: open5gs-master: install dependencies using mk-build-deps ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File open5gs-master/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/27070/comment/ccc18beb_43fe... PS1, Line 31: RUN git clone https://github.com/$GITHUB_USER/$GITHUB_REPO Maybe install dependencies here too? Then it wouldn't need to download all packages from debian/control each time the commit changes, only if new dependencies were added between when the docker container was created and the current master. https://gerrit.osmocom.org/c/docker-playground/+/27070/comment/a0b25a59_c098... PS1, Line 40: mk-build-deps -i -r -t 'apt-get --no-install-recommends -yV' "apt-get build-dep ." should do the same, not sure if it internally uses mk-build-deps. If not, maybe we don't even need this dependency. As mentioned here: https://osmocom.org/projects/cellular-infrastructure/wiki/Build_from_Source#... -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I71ad7256116ee30f15aff38fd38588aa2bfab456 Gerrit-Change-Number: 27070 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Fri, 04 Feb 2022 13:22:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment