Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42657?usp=email )
Change subject: contrib/jenkins.sh: add setup_venv()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/42657/comment/cb5d0a27_2c97b859?usp=ema... :
PS1, Line 7: contrib/jenkins.sh: add setup_venv()
the commit log should ideally state something like 'reduece code duplication by factoring out virtualenv setup in a shell function' or the like.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/42657?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibb193d12d5502c78104ef53badc6037f08e92df1
Gerrit-Change-Number: 42657
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 23 Apr 2026 15:49:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes