Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31062 ) Change subject: Introduce netdev API ...................................................................... Patch Set 2: (1 comment) File src/core/netdev.c: https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/4c67fe8f_6faefbcc PS2, Line 703: / this might be interpreted in a way that one can set/change the ifindex of the actual kernel network device, whcih "obviously" doesn't work. One might call it osmo_netdev_specify_ifindex() to make it a bit more clear. But if we keep the name the documentation should at least be very clear. "Set ifindex of he interface" is misleading. the function set_netns_name below at least states "to use when opening the netdev interface" in the description, which makes it more celar. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7a00c0445a89e088676a4897061b65196d9197f1 Gerrit-Change-Number: 31062 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 24 Jan 2023 17:34:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment