dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43505?usp=email )
Change subject: es9p_client: rephrase TODOs for better understanding ......................................................................
es9p_client: rephrase TODOs for better understanding
Related: SYS#8100 Change-Id: I5ac1f84129e3848ab37a806b3408e38e22810a3e --- M src/es9p_client.erl 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/05/43505/1
diff --git a/src/es9p_client.erl b/src/es9p_client.erl index 7a7fefc..6ab1d58 100644 --- a/src/es9p_client.erl +++ b/src/es9p_client.erl @@ -54,7 +54,8 @@ }, % construct body from encoded json ReqBody = jiffy:encode(JsonBodyWithHdr, [force_utf8]), - % TODO: actually verify the certificate by providing custom root CA Cert + % TODO: Pass proper CA certificate to hackney, so that the eIM can be sure that the identity of the SM-DP+ is + % properly verfied. At the moment we do not verify anything, which is risky. SslOptions = [{verify, verify_none}], Options = [{ssl_options, SslOptions}, with_body], logger:debug( @@ -109,7 +110,8 @@ ], % construct body from encoded ASN.1 {ok, ReqBody} = 'RSPDefinitions':encode('RemoteProfileProvisioningRequest', Asn1Body), - % TODO: actually verify the certificate by providing custom root CA Cert + % TODO: Pass proper CA certificate to hackney, so that the eIM can be sure that the identity of the SM-DP+ is + % properly verfied. At the moment we do not verify anything, which is risky. SslOptions = [{verify, verify_none}], Options = [{ssl_options, SslOptions}, with_body], logger:debug(