Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/aram-applet/+/39615?usp=email ) Change subject: AccessRuleMaster: allow locking of STORE DATA commands ...................................................................... Patch Set 2: (3 comments) File aram/src/main/java/fr/bmartel/aram/AccessRuleMaster.java: https://gerrit.osmocom.org/c/aram-applet/+/39615/comment/5b4aafbc_e2980fbd?u... : PS2, Line 106: ISOException.throwIt(ISO7816.SW_SECURITY_STATUS_NOT_SATISFIED); why is this exception not raised in the INSTALL FOR PERSO case? The only condition for raising it is aram_lock_status, AFAICT. https://gerrit.osmocom.org/c/aram-applet/+/39615/comment/b1725e2d_8594b6a6?u... : PS2, Line 304: this.aram_lock_status = true; mixing tab (new) and space (old) indentation https://gerrit.osmocom.org/c/aram-applet/+/39615/comment/805d2682_1cf9cd99?u... : PS2, Line 307: this.aram_lock_status = false; where is the check that this command is only issued via the INSTALL FOR PERSO ? -- To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: aram-applet Gerrit-Branch: master Gerrit-Change-Id: I86437844585c22fc4280cc48b99edbb56e3159db Gerrit-Change-Number: 39615 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 17:23:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No