Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33770 ) Change subject: rlcmac: Introduce L1CTL-CCCH_READY.ind primitive ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Patchset: PS1:
I'd say we don't need that. […] Ack, I asked just to be sure. Fine then.
File src/rlcmac/gre.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/33770/comment/03d8efc3_1fde6275 PS1, Line 42: struct gprs_rlcmac_entity *gre = data;
I can remove it, I simply thought a reader can quickly find out the gre pointer is already available […] Done
-- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I4cfb1e2db217a97b7a1dc8849cd13d58e4034c56 Gerrit-Change-Number: 33770 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 10:04:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment