neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31082 ) Change subject: coverity: hnbgw_rua.c: remove redundant check ...................................................................... coverity: hnbgw_rua.c: remove redundant check 'map' is already guaranteed to be not NULL for that message type by the preceding switch(). Related: CID#307434 Change-Id: Id30f459616391187aa2f8ad400c316e2144154c6 --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 215379a..2757073 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -253,8 +253,7 @@ prim->u.disconnect.cause = cause; release_context_map = true; /* Mark SCCP conn as gracefully disconnected */ - if (map) - map->scu_conn_active = false; + map->scu_conn_active = false; break; case OSMO_SCU_PRIM_N_UNITDATA: prim->u.unitdata.called_addr = *remote_addr; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id30f459616391187aa2f8ad400c316e2144154c6 Gerrit-Change-Number: 31082 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged