dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43449?usp=email )
Change subject: esipa_asn_handler: add TODO about missing download options ......................................................................
esipa_asn_handler: add TODO about missing download options
SGP.32 also defines other download trigger options next to the commonly used activationCode method. Let's add a related TODO to the code.
Related: SYS#8100 Change-Id: I5e72416284027731627c264fa81c62a4a9a0d407 --- M src/esipa_asn1_handler.erl 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/49/43449/1
diff --git a/src/esipa_asn1_handler.erl b/src/esipa_asn1_handler.erl index c006a7a..f1be50a 100644 --- a/src/esipa_asn1_handler.erl +++ b/src/esipa_asn1_handler.erl @@ -292,6 +292,9 @@ mnesia_db_work:bind(Pid, EimTransactionId), mnesia_db_work:update(Pid, #{}), {[{<<"download">>, {Download}}]} = Order, + % TODO: Add missing download options: This eIM currently only allows to trigger a profile download using + % an activationCode (option a) It still lacks download triggers via SM-DS (option b) and downloads from + % the default SM-DP+ (option c). See also GSMA SGP.32, section 3.2.3.2 ActivationCode = proplists:get_value(<<"activationCode">>, Download), {profileDownloadTriggerRequest, #{ profileDownloadData => {activationCode, ActivationCode},