Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email ) Change subject: tests/vty: Add vty-transcript-test for osmo-stp ...................................................................... Patch Set 3: (1 comment) File tests/vty/osmo_stp_test.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347/comment/fe3b18aa_45b178... : PS3, Line 104: description .TEXT
Wait, this is actually a specific param added in the lib code, so I think yes it should appear here: […] Oh, interesting. So it's defined in libosmovty, but registered here in libosmo-sigtran. I guess it's fine then, as long as we keep the command and its description unchanged.
-- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If2f069b9d724038c326f5c35848faa1e9c216fd5 Gerrit-Change-Number: 38347 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 16:21:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>