Attention is currently required from: falconia, pespin. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/38554?usp=email ) Change subject: csd_v110: set E2 bit correctly for TCH/[FH]4.8 NT ...................................................................... Patch Set 3: Code-Review+2 (2 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/38554/comment/17c725db_061f4024?usp=... : PS2, Line 2066: static const uint8_t tchf48_nt_e2_map[26] = {
Obviously from 3GPP specs. mentioned above in comment... […] Done
https://gerrit.osmocom.org/c/osmo-bts/+/38554/comment/933f74b6_3f5c0c09?usp=... : PS2, Line 2076: uint8_t tchf48_half = tchf48_nt_e2_map[tch_ind->fn % 26];
where dos 26 come from. Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I485af5e01ea87c1721a298a486cd344a17884200 Gerrit-Change-Number: 38554 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: falconia <falcon@freecalypso.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 28 Oct 2024 10:04:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de>