Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43763?usp=email )
Change subject: sccp: Introduce N-DISCONNECT.req/ind Release/Refusal reason ......................................................................
Patch Set 4: Code-Review+1
Copied votes on follow-up patch sets have been updated: * Code-Review+1 has been copied to patch set 5 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN").
(2 comments)
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43763/comment/014e412d_9e8803... : PS4, Line 341: xua_msg_add_u32(xua, SUA_IEI_CAUSE, SUA_CAUSE_T_RELEASE | scu_rel_reason_to_sccp_release_cause(prim->u.disconnect.originator, prim->u.disconnect.cause)); cosmetic: line is too long
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43763/comment/1bde46a7_8997eb... : PS4, Line 376: xua_msg_add_u32(xua, SUA_IEI_CAUSE, SUA_CAUSE_T_REFUSAL | scu_rel_reason_to_sccp_refusal_cause(prim->u.disconnect.originator, prim->u.disconnect.cause)); cosmetic: line is too long