Attention is currently required from: Timur Davydov, fixeria, pespin.
laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42704?usp=email )
Change subject: trx: add JSON stats export for WebSDR API ......................................................................
Patch Set 11:
(2 comments)
Patchset:
PS8:
Similar to the osmo-trx case, this is only built when --with-websdr is enabled, so it does not affec […]
I'm also not a big fan of merging this code. If there was a generic json-serialized exporter for stat_item + rate_ctr, then that should go in libosmocore and might be a useful addition. I personally think it's too CPU-intensive, but every user can be the judge of that.
But adding custom, hand-rolled JSON serialization in the style of bts_to_json is just not something I think we'd want to merge. If at all we can be convinced to accept it, it should be clearly marked as websdr-only, for example by being in a websdr-specific subdirectory (with whatever other websdr related code) so that everyone knows at first sight it is not a general/generic feature of osmo-bts and we as upstream maintainers don't have to look at it.
Patchset:
PS11: I'm also not a fan of merging