laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36634?usp=email ) Change subject: drop legacy hack: do not start MGW endp in loopback mode ...................................................................... drop legacy hack: do not start MGW endp in loopback mode We used to tell osmo-mgw to create an IuUP endpoint in loopback mode, in order to hack it into responding to an IuUP Initialization. The loopback mode here in osmo-hnbgw is a leftover from that hack. Drop it. Change-Id: I0eca75d7abf66f8b9fde9c68ec10d4265f64a189 --- M TODO-RELEASE M src/osmo-hnbgw/mgw_fsm.c 2 files changed, 18 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index b5a838d..a80e188 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,4 +7,7 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -osmo-iuh >1.5.0 proper decoding of X.213 IPv4 address len=7 \ No newline at end of file +osmo-iuh >1.5.0 proper decoding of X.213 IPv4 address len=7 + +MGW MGCP CRCX osmo-hnbgw used to CRCX in loopback mode, to trigger a legacy IuUP hack. CRCX is no + longer in loopback mode now, so older osmo-mgw may fail to respond to IuUP Initialization. diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index d0dc6df..48b4899 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -175,7 +175,7 @@ mgw_info = (struct mgcp_conn_peer) { .call_id = (map->rua_ctx_id << 8) | mgw_fsm_priv->rab_id, .ptime = 20, - .conn_mode = MGCP_CONN_LOOPBACK, + .conn_mode = MGCP_CONN_RECV_SEND, }; mgw_info.codecs[0] = CODEC_IUFP; mgw_info.codecs_len = 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36634?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0eca75d7abf66f8b9fde9c68ec10d4265f64a189 Gerrit-Change-Number: 36634 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged