pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37314?usp=email ) Change subject: asterisk: IMS: Fix INVITE Contact header validation ...................................................................... asterisk: IMS: Fix INVITE Contact header validation Related: SYS#6984 Change-Id: Icfc055859527c9c09ba0fa2648a85ac2ac2fa0bb --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index af44647..32c129e 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -381,7 +381,7 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str(g_name & ": Received unexpected empty Contact attributes (omit)")); } - f_sip_param_match_value_or_fail(caddr.contactParams, "+g.3gpp.icsi-ref", "\"urn\\%3Aurn-7\\%3A3gpp-service.ims.icsi.mmtel\""); + f_sip_param_match_value_or_fail(caddr.contactParams, "+g.3gpp.icsi-ref", "\"urn%3Aurn-7%3A3gpp-service.ims.icsi.mmtel\""); f_sip_param_match_value_or_fail(caddr.contactParams, "+sip.instance", "\"<urn:gsma:imei:" & g_pars.subscr.imei & ">\""); f_sip_param_match_value_or_fail(caddr.contactParams, "audio", omit); @@ -478,7 +478,7 @@ } /* GSMA FCM.01 3.2.3.3: "The INVITE request contains Within the Contact header [...] the IMS * Communication Service Identifier's (ICSI) for IMS Multimedia Telephony" */ - f_sip_param_match_value_or_fail(caddr.contactParams, "+g.3gpp.icsi-ref", "\"urn\\%3Aurn-7\\%3A3gpp-service.ims.icsi.mmtel\""); + f_sip_param_match_value_or_fail(caddr.contactParams, "+g.3gpp.icsi-ref", "\"urn%3Aurn-7%3A3gpp-service.ims.icsi.mmtel\""); /* "The UE must include the audio media feature tag, as defined in IETF RFC 3840, * in the Contact header field of the SIP INVITE request, and in the Contact header * field of the SIP response to the SIP INVITE request" */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37314?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icfc055859527c9c09ba0fa2648a85ac2ac2fa0bb Gerrit-Change-Number: 37314 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged