Attention is currently required from: roox, tnt, roh. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27017 ) Change subject: icE1usb: Move GPS-DO USB control to separate USB interface ...................................................................... Patch Set 1: (1 comment) Patchset: PS1:
Looks good. The minor details I'm not sure about : […] protocols: Yes, I figured the same, but thought that 0x00... 0xcf is by far sufficient for new frame formats, so 0xD0 ("DO") can be used for the GPS-DO?
requests: I thought it's good if they don't overlap with the interface requests to the E1 interface so we possibly more easily catch them if sent to the wrong interface. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Icd6555a14896c38626fb147b78af44ff719f2254 Gerrit-Change-Number: 27017 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: roh <jsteiger@sysmocom.de> Gerrit-Reviewer: roox <mardnh@gmx.de> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Attention: roox <mardnh@gmx.de> Gerrit-Attention: tnt <tnt@246tNt.com> Gerrit-Attention: roh <jsteiger@sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jan 2022 11:46:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt <tnt@246tNt.com> Gerrit-MessageType: comment