msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/31859 ) Change subject: libgsmhr: make use of unused LIBVERSION variable ...................................................................... Patch Set 1: (1 comment) File libgsmhr/Makefile.am: https://gerrit.osmocom.org/c/gapk/+/31859/comment/65a1fdc9_8e45efee PS1, Line 3: # documentation before making any modification I think it's better to add link to the documentation directly (similar to libosmocore): https://www.gnu.org/software/libtool/manual/html_node/Versioning.html Also, it's chapter 7 nowadays but I think with the direct link at hands we can omit the number. -- To view, visit https://gerrit.osmocom.org/c/gapk/+/31859 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I4ef723bdd255fb81393806fdc500dacde2dd917f Gerrit-Change-Number: 31859 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: msuraev <msuraev@sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 20:25:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment