Attention is currently required from: fixeria, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32630 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ......................................................................
Patch Set 5:
(4 comments)
File include/osmo-bts/bts.h:
https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/f99bfe48_97638d46 PS4, Line 71: 101.138
TS 101. […]
Done
File src/common/bts.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/ad1db125_dc07d005 PS4, Line 208: 101.138
TS 101. […]
Done
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/33f3f112_2e9c7004 PS4, Line 1955: /* Since we already verified the payload in rtppayload_validate_hr(), we may trust that the payload length is
Agreeing with pespin here, his proposed approach looks more readable. […]
thanks.
File src/osmo-bts-virtual/main.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/9bd1b5ed_89b40194 PS4, Line 76: BTS_INTERNAL_FLAG_SPEECH_H_V1_RTP_RFC5993
I am not 100% sure, but osmo-bts-virtual should in theory support both formats.
osmo-bts-virtual does not use gsm0503_tch_hr_encode/decode, so I think you are right.