18 Aug
2024
18 Aug
'24
10:46 a.m.
Attention is currently required from: neels.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37804?usp=email )
Change subject: erab_fsm: implement handling of GTP-U address ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/erab_fsm.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37804/comment/634ff4dd_89d11... : PS2, Line 99: %% @param TA TEID and bind address indicated by the MME.
Good to know, thanks for letting me know! I'll consider renaming in a separate patch.
In the end, I simply amended this patch. Re-applying your CR.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37804?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ifdc492c41266d07d0e951dcdcc1e4ba74da0b13b
Gerrit-Change-Number: 37804
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Sun, 18 Aug 2024 08:46:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels nhofmeyr@sysmocom.de
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de