Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33223 )
Change subject: l1gprs: implement TBF starting time support ......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10: @fixeria see fix patch v9->v10. Unfortunately, now that the changes are scheduled on time (and not before the expected time), new problems show up:
At TBF_START_TIME=N, in l1gprs_handle_dl_block_ind() we activate a pending TBF in l1gprs_check_pending_tbfs(), and then send primitive L1CTL_GPRS_DL_BLOCK_IND to upper layers. Further up, in modem app, handle_pdch_block_ind() uses the L1CTL_GPRS_DL_BLOCK_IND primitive to generate an RTS.ind for next_block(N).
As a result, if we configure a TBF for TBF_START_TIME=N, we receive the first RTS.ind for N+4 or N+5..... this is completely unexpected and wrong imho.
I think we should move the RTS.ind down to the l1gprs, and activate TBFs before triggering RTS.ind there.