Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35914?usp=email ) Change subject: gsm: add TCH block/lchan definitions for CSD ...................................................................... Patch Set 3: (1 comment) File include/osmocom/gsm/gsm44021.h: https://gerrit.osmocom.org/c/libosmocore/+/35914/comment/9557c7d9_e30847e6 PS3, Line 17: extern const struct osmo_csd_tch_lchan_desc osmo_csd_chan_mode_rate_desc[256]; BTW, now that we are moving this into a library, I think it makes more sense to have an API (function to obtain a const pointer to struct osmo_csd_tch_lchan_desc, rather than having the table accessible directly. This has several benefits: - Keep the table size smaller and being able to extend it later if needed. - offset checks - Extend the struct osmo_csd_tch_lchan_desc struct if needed without breaking apps. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35914?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie230e09d496c9b791981d8ee04902fc9966ed6d7 Gerrit-Change-Number: 35914 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 12 Feb 2024 09:29:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment