Attention is currently required from: dexter, fixeria, laforge. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42674?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by dexter, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: SmspTpScAddr: fix SMSP record length and alpha_id padding ...................................................................... SmspTpScAddr: fix SMSP record length and alpha_id padding apply_val() was re-encoding the SMSP with the minimum total_len of 28, which produces a 28-byte body with no alpha_id field. After a DER round-trip, the profile machinery re-pads the body to the original record length using the template's fill pattern, which may not be 0xFF. Those non-0xFF fill bytes end up in the alpha_id area, and GSM 7-bit decoding then fails with a KeyError when the modified profile is read back. Fix by: - setting alpha_id = '' so the field is present but empty - setting f_smsp.rec_len = 42 (28 fixed bytes + 14 bytes of alpha_id padding) so the re-encoded body carries 0xFF-padded alpha_id space and the efFileSize in the fileDescriptor stays consistent - passing total_len=f_smsp.rec_len to encode_record_bin() so the alpha_id area is actually padded to that length Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296 Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/74/42674/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296 Gerrit-Change-Number: 42674 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de>