Attention is currently required from: dexter.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42155?usp=email )
Change subject: esim/http_json_api.py: support text/plain response Content-Type ......................................................................
Patch Set 5:
(1 comment)
File pySim/esim/http_json_api.py:
https://gerrit.osmocom.org/c/pysim/+/42155/comment/2303fe74_66323951?usp=ema... : PS5, Line 431: if 'header' in output:
I think you should draw this header check into the conditional branch because when we decode a plain […]
This is not matching some plaintext blob. 'output' is a dict, the 'in' operator here looks up a dict key which must be exactly 'header', case sensitive and full match.