Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 ) Change subject: bladerf xa4 support ...................................................................... Patch Set 2: (2 comments) File Transceiver52M/device/bladerf/bladerf.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/62fe1f31_f2262ca9 PS1, Line 432: // Initialize and shadow gain values
The file is literally copypasted from the b210 code and those comments are useless anyway... Done
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/cc218d2d_eff7db90 PS1, Line 727: #ifndef IPCMAGIC
This is related to the ipc interface test that uses the uhd backend for the ipc side,which is where […] Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac Gerrit-Change-Number: 30413 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 14:42:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment