Attention is currently required from: daniel. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email ) Change subject: gtp: add support for SGSN Context Req/Resp/Ack ...................................................................... Patch Set 18: (3 comments) This change is ready for review. File gtp/gtp.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/2eafc786_d284ba98?usp... : PS11, Line 1152: // SAPI
Change to C-style comments Done
File include/osmocom/gtp/gsn.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/dc4b2e59_e5034f8a?usp... : PS7, Line 116: int (*cb_sgsn_context_request_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size);
I'll keep this "wrong" spaced function pointer, because all other functions in here o it as well. […] Done
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/bf3db206_d9337ead?usp... : PS7, Line 169: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size));
I'll keep this "wrong" spaced function pointer, because all other functions in here o it as well. […] Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 Gerrit-Change-Number: 38938 Gerrit-PatchSet: 18 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jun 2025 17:22:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann@sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>