Attention is currently required from: fixeria, lynxis lazus, pespin.
daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email )
Change subject: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails ......................................................................
Patch Set 2:
(1 comment)
File src/tcap_as_loadshare.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686/comment/a61aa9b7_4172f0... : PS2, Line 555: tcap_trans_track_entry_create(as, asp, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid);
just to make sure: do you need to call tcap_trans_track_continue() again once finally the asp is sel […]
IMO no. The function sets otid/dtid if not already known, updates the timestamp and returns the asp.
We already have the asp and just created a complete entry as otid/dtid are already known from the continue.