10 Aug
2023
10 Aug
'23
8:27 p.m.
Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34129 )
Change subject: l1ctl: Fix fill ph_data_param fn field ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmocom-bb/+/34129/comment/ff4533c7_fa92a038 PS1, Line 7: Fix fill ph_data_param fn field
A more usual way to say that you're fixing a previously merged commit is "fixup: ...".
I added "Fixes:" tag at the bottom, that's enough imho.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34129
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id96015c8b419932abb8095c6cb85aceef34e366f
Gerrit-Change-Number: 34129
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 10 Aug 2023 18:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment