Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31112 ) Change subject: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/31112/comment/d021fa43_acf0bea3 PS1, Line 13: actively manage the channel than. In the case of Ericsson we have to "the channel than" I don't understand this part. File src/osmo-bsc/timeslot_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31112/comment/f9785853_647641b0 PS1, Line 343: case GSM_PCHAN_PDCH: IIRC we have already a specific function checking the timeslot configuration restictions for each/all BTS. This code should go there imho, to prevent users from configuring channels as PDCH if BTS type is ericcsson. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc7c2956fc934691e3bfacb283d896a8767baf27 Gerrit-Change-Number: 31112 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jan 2023 17:38:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment