Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: layer23: migrate away from deprecated gsm48_mi_to_string ...................................................................... Patch Set 4: -Code-Review (1 comment) Patchset: PS4:
did you test this manually using osmocombb against a network? I gave this patch a try, and there is a little problem:
``` DRR NOTICE app_ccch_scan.c:285 Paging1: Normal paging chan any to tmsi M(TMSI-0xE8D0A894) ``` so now ccch_scan is printing the MI type twice. I will fix this. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ida67adaa61689c55505a89e1a1bebde041c91139 Gerrit-Change-Number: 33317 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Mon, 08 Jan 2024 14:31:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment