Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29001 ) Change subject: build: add --enable-pfcp, make PFCP dep optional ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2:
Do we really want to disable PFCP support at build time? Is that really going to be used and it is w […] our existing apporoach is to try to minimize dependencies, see osmo-msc with default-off for smpp or Iu support.
The advantage of this approach is that it makes it easier for people to build a simple/typical setup from source, without cursing over all the dependencies. For our package feeds it's not an issue as we can simply pass --enable-foo in the debian/rules. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I6d50c60bccda767910217243bdfb4a6fad1e39c1 Gerrit-Change-Number: 29001 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 09 Aug 2022 16:34:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment