fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42515?usp=email )
Change subject: measurement: is_meas_complete(): fix fn_mod variable type ......................................................................
measurement: is_meas_complete(): fix fn_mod variable type
`fn_mod` was declared as 'unsigned int' but initialized to -1, which yields `UINT_MAX` via implicit conversion. Use 'int' instead to make the sentinel value unambiguous and match the `%d` format used in the debug log.
Change-Id: I6b0bce9bc9fca1d6effbb2da2319132cdff4e9c7 --- M src/common/measurement.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified
diff --git a/src/common/measurement.c b/src/common/measurement.c index 19bff71..afbdc84 100644 --- a/src/common/measurement.c +++ b/src/common/measurement.c @@ -252,7 +252,7 @@ * unit-tests) */ int is_meas_complete(struct gsm_lchan *lchan, uint32_t fn) { - unsigned int fn_mod = -1; + int fn_mod = -1; const uint8_t *tbl; int rc = 0; enum gsm_phys_chan_config pchan = ts_pchan(lchan->ts);