Attention is currently required from: laforge, neels, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/43480?usp=email )
Change subject: libvlr: auth: never re-use auth tuples for authentication ......................................................................
Patch Set 1:
(5 comments)
Patchset:
PS1:
I think there was an ancient use case for this in some weird hackish setup where during some kind of […]
I re-considered this commit. I'll try to improve the ciphering usage. Still keep the re-use auth tuples, which is by default 0, but allow to re-use the same key slot for ciphering multiple times.
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/39a13b83_005c20a0?usp=... : PS1, Line 9: The auth tuples should only ever sent once over the air for authentication.
ever be sent
Done
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/571dbe3e_a3350ff8?usp=... : PS1, Line 9: The auth tuples should only ever sent once over the air for authentication.
ever be sent
Done
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/3b746fd9_09458f91?usp=... : PS1, Line 11: be re-used other the air for authentication.
over the air
Done
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/4f1eb5cb_2f22c049?usp=... : PS1, Line 11: be re-used other the air for authentication.
over the air
Done