fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28979 ) Change subject: split lchan specific defines and code to its own file ...................................................................... Patch Set 3: (1 comment) Patchset: PS2:
You need to first know exactly what you want to find before start using grep, so first step is openi […] The point of `git grep ...` is exactly to allow finding stuff without prior knowledge of the exact file ;) Personally I would not say "really difficult". It used to be quite simple: open gsm_data.h and you'll find everything in there. With ctags you also don't need to care that much. But from the hierarchical point of view it indeed makes more sense to have a separate header per a logical component.
-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idd855d126c43ac6576c5f3ba7e0b8014127a65e1 Gerrit-Change-Number: 28979 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 09 Aug 2022 09:04:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment