Attention is currently required from: dexter, jolly.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42833?usp=email )
Change subject: certificates: add checks to make sure cert and key files are readable ......................................................................
Patch Set 1:
(3 comments)
File src/crypto_utils.erl:
https://gerrit.osmocom.org/c/onomondo-eim/+/42833/comment/e859a5c0_20b0b0d9?... : PS1, Line 214: RootCiCertPem = case file:read_file(RootCiCertPath) of cosmetic: you're adding tabs to a file that uses spaces
https://gerrit.osmocom.org/c/onomondo-eim/+/42833/comment/95124dca_a1aa1f5a?... : PS1, Line 218: throw `throw` is normally used to break long recursion chains. `erlang:error/1` is a better fit for signalling a run-time error.
File src/onomondo_eim_app.erl:
https://gerrit.osmocom.org/c/onomondo-eim/+/42833/comment/a64f1537_7b77dcf9?... : PS1, Line 35: true -> likewise: use spaces (not tabs) and `erlang:error/1`.