Attention is currently required from: osmith, laforge, fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33571 ) Change subject: MME_Tests: add docker tests for MME ...................................................................... Patch Set 2: (4 comments) File debian-bullseye-titan/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/33571/comment/ffd8ba65_3a69... PS1, Line 34: libgnutls28-dev
Could you also clarify why this new dependency is needed (in the commit message)? I am guessing the […] Done
https://gerrit.osmocom.org/c/docker-playground/+/33571/comment/6e51d518_6659... PS1, Line 34: libgnutls28-dev \
move after inetutils-ping, so the list is still ordered alphabetically Done
File ttcn3-mme-test-ogs/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/33571/comment/91862cfc_98c6... PS1, Line 5: KERNEL_TEST="${KERNEL_TEST:-0}"
unused Done
https://gerrit.osmocom.org/c/docker-playground/+/33571/comment/202a32d9_8030... PS1, Line 27: --cap-add=NET_ADMIN \ : --device /dev/net/tun:/dev/net/tun \ : --sysctl net.ipv6.conf.all.disable_ipv6=0 \
The feature is enabled simply to make sure it is used and spot regressions/changes in the feature fo […] The tun device is definitely not needed. I also dropped the so_bindtodevice. There are no changes in the behavior.
-- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic1ce1dace47353b0dcf321c923a78567e3ddefb9 Gerrit-Change-Number: 33571 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jul 2023 14:22:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de> Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment