Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27567 ) Change subject: library/BSSMAP_Templates: add missing LCS {Priority,QoS} IEs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File library/BSSMAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27567/comment/730a157f_30a20... PS1, Line 1908: rTC := '00'B /* Response Time is not specified */ so many magic numbers... i guess it would be quite some effort to define these values in enums? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27567 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2bd6e636d3ee695abab9ed40417dc53ec68fd12 Gerrit-Change-Number: 27567 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Wed, 23 Mar 2022 15:29:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment