fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/42603?usp=email )
Change subject: csn1: ProcessError_impl(): add a missing newline ......................................................................
csn1: ProcessError_impl(): add a missing newline
The comment about caller's responsibility is wrong and misleading. The caller provides format string parameters, not the format string!
Change-Id: I0f7c0a6d25db03c1fe8503b57053130ed29baf23 --- M src/csn1/csn1.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/03/42603/1
diff --git a/src/csn1/csn1.c b/src/csn1/csn1.c index 5eb35ea..ac418d7 100644 --- a/src/csn1/csn1.c +++ b/src/csn1/csn1.c @@ -93,9 +93,8 @@ gint16 ProcessError_impl(const char *file, int line, unsigned *readIndex, const char* sz, gint16 err, const CSN_DESCR* pDescr) { - /* Don't add trailing newline, top caller is responsible for appending it */ if (err != CSN_OK) - LOGPSRC(DLCSN1, LOGL_ERROR, file, line, "%s: error %s (%d) at %s (idx %u)", + LOGPSRC(DLCSN1, LOGL_ERROR, file, line, "%s: error %s (%d) at %s (idx %u)\n", sz, get_value_string(csn1_error_names, err), err, pDescr ? pDescr->sz : "-", *readIndex); return err;