Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37554?usp=email ) Change subject: library/GTPv1C_Templates: Introduce template ts_GTPC_UpdatePdpRespGGSN ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File library/GTPv1C_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37554/comment/5d5c440e_31511... PS2, Line 1047: ts_UpdatePdpRespGGSNPDU why not just letting the caller pass a template param with all these params? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I91afc14eecfadb3e00ccb9b74794079a82ef884b Gerrit-Change-Number: 37554 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jul 2024 21:11:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment