Attention is currently required from: jolly. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email ) Change subject: Add functions to events from server to client ...................................................................... Patch Set 1: (4 comments) File src/e1d.h: https://gerrit.osmocom.org/c/osmo-e1d/+/35558/comment/649f92f1_bbc8002d PS1, Line 199: void *srv; I don't see this used in this patch ? File src/osmo-e1gen.c: https://gerrit.osmocom.org/c/osmo-e1d/+/35558/comment/9ba66239_4188d570 PS1, Line 440: void osmo_e1dp_server_event(void) {} Why do we need this ? File src/proto_clnt.c: https://gerrit.osmocom.org/c/osmo-e1d/+/35558/comment/70b90548_b895f9d7 PS1, Line 72: void (*event_cb)(enum osmo_e1dp_msg_type event, uint8_t intf, uint8_t line, uint8_t ts, uint8_t *data, int len); Maybe typedef some type osmo_e1dp_event_cb_t or something ? https://gerrit.osmocom.org/c/osmo-e1d/+/35558/comment/a87dec01_3c94de1b PS1, Line 85: clnt->event_cb(hdr->type, hdr->intf, hdr->line, hdr->ts, msgb_l1(msgb) + sizeof(*hdr), msgb_l1len(msgb) - sizeof(*hdr)); Shouldn't msgb_l2() work ? And if not, having the l2h set by earlier code would probably be good. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I5ee3268f8349b611c3cf3fa0572dc5eab280ab2e Gerrit-Change-Number: 35558 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Comment-Date: Sun, 14 Jan 2024 18:22:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment