neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40829?usp=email ) Change subject: use random.SystemRandom as random nr source (/dev/urandom) ...................................................................... use random.SystemRandom as random nr source (/dev/urandom) /dev/urandom is somewhat better than python's PRNG Change-Id: I6de38c14ac6dd55bc84d53974192509c18d02bfa --- M pySim/esim/saip/param_source.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/29/40829/1 diff --git a/pySim/esim/saip/param_source.py b/pySim/esim/saip/param_source.py index aaef68a..46a04fb 100644 --- a/pySim/esim/saip/param_source.py +++ b/pySim/esim/saip/param_source.py @@ -94,7 +94,7 @@ return cls(cls.expand_str(s)) class RandomSourceMixin: - random_impl = random # TODO secure random source? + random_impl = random.SystemRandom() class RandomDigitSource(InputExpandingParamSource, RandomSourceMixin): 'return a different sequence of random decimal digits each' -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6de38c14ac6dd55bc84d53974192509c18d02bfa Gerrit-Change-Number: 40829 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de>