Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email ) Change subject: fixup: rsl: properly initialize MS/BS Power Control state ...................................................................... Patch Set 1: (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/b1b5ca6f_efcbed57?usp=... : PS1, Line 2059: lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max;
I suggest you to check the old code (left side of diff). […] Before, we were doing it in the branch TLVP_PRES_LEN(), but now you are doing it always, that's the difference I'm mentioning.
-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98 Gerrit-Change-Number: 39830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 17:24:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de>