Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43657?usp=email )
Change subject: IPAd: Add test to verify IPAd polling from two eIMs ......................................................................
Patch Set 1:
(3 comments)
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43657/comment/0f951843_a91e2... : PS1, Line 805: var charstring eim_fqdn := mp_esipa_ip & ":" & int2str(mp_esipa_port); Is the eim_fqdn variable still needed? I don't see where it is used here...
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43657/comment/63396b9b_9da78... : PS1, Line 807: f_package_euicc_data_req(id, "myEIM_1"); in case you decide to follow the array approach, you could pull the eimId strings form the array in pars.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43657/comment/92907483_09024... : PS1, Line 813: f_eim_init(); The f_eim_init function is called by f_es10x_init. Now it is called again here and it is not immediately obvious for someone who reads this where f_eim_init is called the first time. Maybe we should not call f_eim_init from f_es10x_init and put the call after f_es10x_init where it is needed.
The downside of this is that we have do do it in each test then. I also wonder if it sis possible to put all those boilerplate calls into the f_init_handler handler function. But as far as I can see the boilerplate code is not exactly the same in all tests. So some logic is needed.
But then, the f_eim_init() call is again orphaned. What a pity... Then let's keep it where it is, but addressing the boilerplate problem would be worthwhile I think.
In any case this is definitely be a topic for a follow up patch.