Attention is currently required from: osmith, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33591 ) Change subject: csd_bs_list_to_gsm0808_channel_type: add T 300 ...................................................................... Patch Set 2: (2 comments) File src/libmsc/csd_bs.c: https://gerrit.osmocom.org/c/osmo-msc/+/33591/comment/03458eba_a3a8c935 PS1, Line 187: GSM0808_DATA_HALF_LM
See my comment below, I think either TCH/H2.4 or TCH/F2. […] I agree
https://gerrit.osmocom.org/c/osmo-msc/+/33591/comment/2b0d2ea8_290eb48c PS1, Line 196: GSM0808_DATA_FULL_BM
Rates below 9600 can be carried over half-rate channels too, since we have TCH/H4.8 and TCH/H2.4. […] technically it is true, one can carry those rates over TCH/H. I'm not sure how good a policy decision it is, given that TCH/F provides so much more redundancy and hence robustness...
-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7297cc481fbe36355b5231ca800cf566a1ee93c0 Gerrit-Change-Number: 33591 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jul 2023 07:51:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment