Attention is currently required from: dexter, lynxis lazus.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43953?usp=email )
Change subject: gprs_sndcp_xid: fix length check in gprs_sndcp_compile_xid ......................................................................
Patch Set 1:
(2 comments)
File src/sgsn/gprs_sndcp_xid.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/43953/comment/94a537e7_1726fe6d?usp... : PS1, Line 596: VTVLV_GAN_GROSS_LEN Any reason to use GAN specific macros here? Why not plain `TLV_GROSS_LEN`?
https://gerrit.osmocom.org/c/osmo-sgsn/+/43953/comment/a01db40f_8b9e4570?usp... : PS1, Line 609: SNDCP_XID_DATA_COMPRESSION ```suggestion byte_counter += VTVLV_GAN_GROSS_LEN(SNDCP_XID_PROTOCOL_COMPRESSION, rc); ```